[Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 8 05:37:12 PDT 2016


labath added inline comments.

================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:98
@@ +97,3 @@
+    const ArchSpec &arch = m_thread.GetProcess()->GetTarget().GetArchitecture();
+    RegisterInfo* reg_info = const_cast<RegisterInfo *>(m_reg_info.GetRegisterInfoAtIndex (reg));
+    if(reg_info->dynamic_size_dwarf_len)
----------------
Can we get rid of these const_casts? It looks like UpdateDynamicRegisterSize does not actually need this to be non-const.


Repository:
  rL LLVM

http://reviews.llvm.org/D20357





More information about the lldb-commits mailing list