[Lldb-commits] [PATCH] D18481: Add argument to expectedFailureAll decorator to xfail for environment variables, and xfail tests for hard float abi and -mthumb on android arm
Ying Chen via lldb-commits
lldb-commits at lists.llvm.org
Fri Mar 25 14:58:39 PDT 2016
chying added a comment.
In http://reviews.llvm.org/D18481#383718, @zturner wrote:
> Couldn't we have a way to say in the Makefile "never use these flags", then the test suite could check the environment and remove them if they are present. This woudl allow the test to run.
> architecture, compiler, etc are things we don't really have control over. If a flag or an environment variable is causing a test to fail, it seems like the right thing to do is not to use that flag or environment variable.
I don't find a way to pass compiler flags to test suite by current dotest options (please let me know if there is), so they're passed by CFLAGS_EXTRAS variable, which is checked and applied in the main Makefile. Alternative would be adding new dotest options to take compiler flags, then we add xfail based on compiler flag, please let me know how you think about this approach.
In http://reviews.llvm.org/D18481#383720, @zturner wrote:
> I'll still wait and see what Pavel and/or Tamas say, but if we are going to go this route, I would rather the argument be called `cflags` and not `env_flags`. Xfailing a test based on an arbitrary environment variable just seems like something we shouldn't be doing. I'd rather prime the environment however we need in order to get the test to run, than disable it and lose test coverage.
Yes, let's get more opinions on this.
More information about the lldb-commits