[Lldb-commits] [PATCH] D18481: Add argument to expectedFailureAll decorator to xfail for environment variables, and xfail tests for hard float abi and -mthumb on android arm
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Fri Mar 25 13:56:49 PDT 2016
zturner added a comment.
I'll still wait and see what Pavel and/or Tamas say, but if we are going to go this route, I would rather the argument be called `cflags` and now `env_flags`. Xfailing a test based on an arbitrary environment variable just seems like something we shouldn't be doing. I'd rather prime the environment however we need in order to get the test to run, than disable it and lose test coverage.
More information about the lldb-commits