[Lldb-commits] [lldb] r258546 - Silence -Wreturn-type warnings

[Saleem Abdulrasool via lldb-commits]

On Sat, Jan 23, 2016 at 3:24 PM, Joerg Sonnenberger <joerg at britannica.bec.de
> wrote:

> On Fri, Jan 22, 2016 at 08:26:30PM -0000, Saleem Abdulrasool via
> lldb-commits wrote:
> > Author: compnerd
> > Date: Fri Jan 22 14:26:30 2016
> > New Revision: 258546
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=258546&view=rev
> > Log:
> > Silence -Wreturn-type warnings
> >
> > Address a couple of instances of -Wreturn-type warning from GCC.  The
> switches
> > are covered, add an llvm_unreachable to the end of the functions to
> silence the
> > warning.  NFC.
>
> Huh? This is wrong. A switch with a default branch should never trigger
> a fall through waring.


You're right.  I think that this was rebased over another change and I
failed to notice that this was now default'ed.  Reverted in SVN r258821.


>
> Joerg
>



-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160126/7b24c6c7/attachment.html>