[Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

[Zachary Turner via lldb-commits]

It would be a great start if we could just get everyone to actually run
clang-format manually.  There are two outstanding issues with clang-format
that dont' support LLDB style.  Those two issues would go away if: 1) LLDB
abandoned those styles and adoped LLVM's style (preferred), or 2) I fix
clang-format to support them.  I keep promising to do #2, but I haven't yet
because it seems like I'm the only using clang-format anyway.  If there
were assurances that more people would start using it, I would
re-prioritize.

On Fri, Dec 11, 2015 at 2:12 PM Zachary Turner <zturner at google.com> wrote:

> On Fri, Dec 11, 2015 at 2:11 PM Todd Fiala via lldb-commits <
> lldb-commits at lists.llvm.org> wrote:
>
>> On Fri, Dec 11, 2015 at 2:02 PM, Eugene Zelenko <eugene.zelenko at gmail.com
>> > wrote:
>>
>>> Hi, Todd!
>>>
>>> As far as I know Clang-format doesn't leave spaces. Somebody pointed
>>> to old discussion on this matter, but I forgot it locations :-(
>>>
>>> I think will be good idea to implement automatic run of Clang-format
>>> as pre-commit hook, since LLDB code have too much diversity in code
>>> formatting for single project.
>>>
>>
>> I like the pre-commit hook idea.  Have we attempted to pursue this in the
>> past?
>>
>
> Biggest problem with commit hook is that it will format lines that you
> specifically don't want formatted.  See for example all the option tables
> in Command*.cpp files
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20151211/455cef6f/attachment.html>