[Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 11 14:12:53 PST 2015

On Fri, Dec 11, 2015 at 2:11 PM Todd Fiala via lldb-commits <
lldb-commits at lists.llvm.org> wrote:

> On Fri, Dec 11, 2015 at 2:02 PM, Eugene Zelenko <eugene.zelenko at gmail.com>
> wrote:
>> Hi, Todd!
>> As far as I know Clang-format doesn't leave spaces. Somebody pointed
>> to old discussion on this matter, but I forgot it locations :-(
>> I think will be good idea to implement automatic run of Clang-format
>> as pre-commit hook, since LLDB code have too much diversity in code
>> formatting for single project.
> I like the pre-commit hook idea.  Have we attempted to pursue this in the
> past?

Biggest problem with commit hook is that it will format lines that you
specifically don't want formatted.  See for example all the option tables
in Command*.cpp files
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20151211/4f5f3fdb/attachment.html>

More information about the lldb-commits mailing list