[Lldb-commits] [PATCH] D9740: Add MiSyntaxTestCase.test_lldbmi_output_grammar test (MI)

[Ilia K]

ki.stfu added inline comments.

================
Comment at: test/tools/lldb-mi/syntax/TestMiSyntax.py:108
@@ +107,3 @@
+        command       = "^\r\n"                 # 5 (it looks like empty line for pexpect)
+        error         = "^.+?\n"                # 6
+        import pexpect                          # 7 (EOF)
----------------
abidh wrote:
> This is not being used.
It refers to line #156. I may add an assert(matched_pattern == error) there.

================
Comment at: test/tools/lldb-mi/syntax/TestMiSyntax.py:116
@@ +115,3 @@
+
+        next_state = get_state(command)
+        while True:
----------------
abidh wrote:
> What it means to be in command state?
That lldb-mi has nothing to do until we type a next command. For example, after lldb-mi startup.

================
Comment at: tools/lldb-mi/MIDriver.cpp:595
@@ -594,3 +593,1 @@
-    m_rStdOut.WriteMIResponse("\n", false);
-
     return MIstatus::success;
----------------
abidh wrote:
> You can commit this line separately. It does not seem to related to this patch.
It causes a failure of the added test.


http://reviews.llvm.org/D9740