[Lldb-commits] [PATCH] D9740: Add MiSyntaxTestCase.test_lldbmi_output_grammar test (MI)

[Hafiz Abid Qadeer]

abidh requested changes to this revision.
abidh added a comment.
This revision now requires changes to proceed.

This test is failing on Linux. I am trying to understand how this test is supposed to work. Please add some more comments and then I can debug why it is failing on Linux.


================
Comment at: test/tools/lldb-mi/syntax/TestMiSyntax.py:108
@@ +107,3 @@
+        command       = "^\r\n"                 # 5 (it looks like empty line for pexpect)
+        error         = "^.+?\n"                # 6
+        import pexpect                          # 7 (EOF)
----------------
This is not being used.

================
Comment at: test/tools/lldb-mi/syntax/TestMiSyntax.py:114
@@ +113,3 @@
+        def or_op(x, y):       return x | y
+        def get_state(*args):  return reduce(or_op, map(get_mask, args))
+
----------------
Add some comments to describe what these functions are meant to do.

================
Comment at: test/tools/lldb-mi/syntax/TestMiSyntax.py:116
@@ +115,3 @@
+
+        next_state = get_state(command)
+        while True:
----------------
What it means to be in command state?

================
Comment at: tools/lldb-mi/MIDriver.cpp:595
@@ -594,3 +593,1 @@
-    m_rStdOut.WriteMIResponse("\n", false);
-
     return MIstatus::success;
----------------
You can commit this line separately. It does not seem to related to this patch.


http://reviews.llvm.org/D9740