[Lldb-commits] [PATCH] D11309: Detect if necessary to build inferior with -pie for Android.

[Chaoren Lin]

Ah okay, we'd need to update some comments in Android.cmake too then.

On Fri, Jul 17, 2015 at 1:25 PM, Dan Albert <danalbert at google.com> wrote:

> danalbert requested changes to this revision.
> danalbert added a reviewer: danalbert.
> This revision now requires changes to proceed.
>
> ================
> Comment at: test/lldbtest.py:1993
> @@ +1992,3 @@
> +            dictionary["OS"] = "Android"
> +            if android_device_api() > 14:
> +                dictionary["PIE"] = 1
> ----------------
> danalbert wrote:
> > I thought this was >= 16. I don't think we supported it in 15.
> Yes, 16 (4.1) was the first to support it:
> https://source.android.com/devices/tech/security/enhancements/enhancements41.html
>
>
> http://reviews.llvm.org/D11309
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150717/caa6f015/attachment.html>