<div dir="ltr">Ah okay, we'd need to update some comments in Android.cmake too then.</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 17, 2015 at 1:25 PM, Dan Albert <span dir="ltr"><<a href="mailto:danalbert@google.com" target="_blank">danalbert@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">danalbert requested changes to this revision.<br>
danalbert added a reviewer: danalbert.<br>
This revision now requires changes to proceed.<br>
<span class=""><br>
================<br>
Comment at: test/lldbtest.py:1993<br>
@@ +1992,3 @@<br>
</span><span class="">+            dictionary["OS"] = "Android"<br>
+            if android_device_api() > 14:<br>
+                dictionary["PIE"] = 1<br>
</span>----------------<br>
<span class="">danalbert wrote:<br>
> I thought this was >= 16. I don't think we supported it in 15.<br>
</span>Yes, 16 (4.1) was the first to support it: <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__source.android.com_devices_tech_security_enhancements_enhancements41.html&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=MEqT8U_n7oNfuDW5NRbY3ZV384ZquXIYFPWmprwUdKM&m=pHm6KbY9kLO3eHHiXR13gWUIZBY38zWY06VDzmQq0So&s=tj0lfWUJ6u6Ug52SJge624YZ89S2mkn-k1j462Om_WQ&e=" rel="noreferrer" target="_blank">https://source.android.com/devices/tech/security/enhancements/enhancements41.html</a><br>
<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11309&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=MEqT8U_n7oNfuDW5NRbY3ZV384ZquXIYFPWmprwUdKM&m=pHm6KbY9kLO3eHHiXR13gWUIZBY38zWY06VDzmQq0So&s=c7YSaFCeFumg9tqgkwiip38YkRNMEdMxhF5l6HcjWYQ&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D11309</a><br>
<br>
<br>
<br>
</blockquote></div><br></div>