[Lldb-commits] [PATCH] Reduce header footprint of Module.h

[Zachary Turner]

Yea I don't plan to impl entire classes.  If I end up with any patches that
I'm unsure about, I'll upload them for you to look at first.

On Tue, Mar 3, 2015 at 10:44 AM Greg Clayton <clayborg at gmail.com> wrote:

> This is fine as long as you don't take a simple class that contains very
> few things (like ClangASTType) and try to hide everything behind a
> unique_ptr just to avoid clang includes. I don't want to trade of compile
> time for run time performance (heap fragmentation).
>
> Your fix in this patch was fine as it moved a ClangASTContext into a
> shared pointer which is fine as it is a large class.
>
> > On Mar 3, 2015, at 10:37 AM, Zachary Turner <zturner at google.com> wrote:
> >
> > Thanks, I'll take this as a sign that it's ok to commit further patches
> of this nature.  Let me know if you have concerns about any of the patches
> I submit.  Removing header file includes from other headers breaks some cpp
> files, so I'll make sure to test on all 3 platforms before comitting
> anything.
> >
> >
> > REPOSITORY
> >  rL LLVM
> >
> > http://reviews.llvm.org/D8022
> >
> > EMAIL PREFERENCES
> >  http://reviews.llvm.org/settings/panel/emailpreferences/
> >
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150303/f0f96b54/attachment.html>