[Lldb-commits] [PATCH] Reduce header footprint of Module.h
clayborg at gmail.com
Tue Mar 3 10:44:19 PST 2015
This is fine as long as you don't take a simple class that contains very few things (like ClangASTType) and try to hide everything behind a unique_ptr just to avoid clang includes. I don't want to trade of compile time for run time performance (heap fragmentation).
Your fix in this patch was fine as it moved a ClangASTContext into a shared pointer which is fine as it is a large class.
More information about the lldb-commits