[Lldb-commits] [PATCH] Fix process's output to stdout/stderr (MI)

Ilia K ki.stfu at gmail.com
Wed Feb 25 11:21:14 PST 2015


In http://reviews.llvm.org/D7858#129828, @clayborg wrote:

> So then my other comment stands: I believe you using std::shared_ptr<char> incorrectly unless the compiler does some magic. I believe your arrays should be declared like:
>
>   std::shared_ptr<char> spStdoutBuffer(new char[1024], std::default_delete<char[]>());
>   
>   


Agree. I'll fix it.

But what about Escape function?? (See my questions above)


http://reviews.llvm.org/D7858

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list