[Lldb-commits] [PATCH] Fix process's output to stdout/stderr (MI)

[Greg Clayton]

I don't know enough to answer if vbEscapeQuotes can be removed. It really depends on what MI needs out of this. If MI wants arguments that are already pulled apart, those arguments should match what a shell would commonly do IMHO, but again, I don't know what MI expects.

> On Feb 25, 2015, at 11:21 AM, Ilia K <ki.stfu at gmail.com> wrote:
> 
> In http://reviews.llvm.org/D7858#129828, @clayborg wrote:
> 
>> So then my other comment stands: I believe you using std::shared_ptr<char> incorrectly unless the compiler does some magic. I believe your arrays should be declared like:
>> 
>>  std::shared_ptr<char> spStdoutBuffer(new char[1024], std::default_delete<char[]>());
>> 
>> 
> 
> 
> Agree. I'll fix it.
> 
> But what about Escape function?? (See my questions above)
> 
> 
> http://reviews.llvm.org/D7858
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
>