[Lldb-commits] [PATCH] Don't use CopyContext in RegisterContextWin

Adrian McCarthy amccarth at google.com
Fri Feb 13 11:51:09 PST 2015


Don't commit yet.

ninja check-lldb was giving me good results last night, but now it never
finishes.  Looks like I get about 15 python_d.exe processes and 3 a.out
processes that hang.  All bug one Python process are consuming no CPU, so
it looks like those are deadlocked.  I'm investigating.

On Fri, Feb 13, 2015 at 10:56 AM, Zachary Turner <zturner at google.com> wrote:

> Looks very nice.  I will commit later this afternoon.  No issues popped up
> while running the test suite I assume?  Same number of failures before and
> after the patch?
>
> I would try setting a breakpoint by line number, then doing a "source
> list" and a "frame info" (I think that's the command anyway to see the
> stack frame), and a "disasm" and make sure all the values look sane.  Of
> course normally the test suite would catch all this, but since it still
> fails for many tests I usually like to do this sanity check first when
> messign with the register stuff (in addition to running the tests obviously)
>
>
> http://reviews.llvm.org/D7572
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150213/ff7a0894/attachment.html>


More information about the lldb-commits mailing list