[Lldb-commits] [PATCH] Don't use CopyContext in RegisterContextWin

Zachary Turner zturner at google.com
Fri Feb 13 10:56:07 PST 2015


Looks very nice.  I will commit later this afternoon.  No issues popped up while running the test suite I assume?  Same number of failures before and after the patch?

I would try setting a breakpoint by line number, then doing a "source list" and a "frame info" (I think that's the command anyway to see the stack frame), and a "disasm" and make sure all the values look sane.  Of course normally the test suite would catch all this, but since it still fails for many tests I usually like to do this sanity check first when messign with the register stuff (in addition to running the tests obviously)


http://reviews.llvm.org/D7572

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list