[Lldb-commits] [PATCH] Clear should reset error to invalid instead of generic
zturner at google.com
Wed Jan 21 18:48:13 PST 2015
It would help to see some context (eg generating the diff with -U999999. I
was trying to find the constructor, because I figure it should reset it to
whatever the constructor initializes it to, but I can't see that here.
Anyway, lgtm as long as this is what the constructor does.
On Wed, Jan 21, 2015 at 6:43 PM Siva Chandra <sivachandra at google.com> wrote:
> Comment at: source/Core/Error.cpp:149
> @@ -148,3 +148,3 @@
> m_code = 0;
> - m_type = eErrorTypeGeneric;
> + m_type = eErrorTypeInvalid;
> Drive by comment:
> While I do not know if this OK or not, you should explain why this change
> is required in your commit message.
> EMAIL PREFERENCES
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits