It would help to see some context (eg generating the diff with -U999999.  I was trying to find the constructor, because I figure it should reset it to whatever the constructor initializes it to, but I can't see that here.<br><br>Anyway, lgtm as long as this is what the constructor does.<br><div class="gmail_quote">On Wed, Jan 21, 2015 at 6:43 PM Siva Chandra <<a href="mailto:sivachandra@google.com">sivachandra@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">================<br>
Comment at: source/Core/Error.cpp:149<br>
@@ -148,3 +148,3 @@<br>
     m_code = 0;<br>
-    m_type = eErrorTypeGeneric;<br>
+    m_type = eErrorTypeInvalid;<br>
     m_string.clear();<br>
----------------<br>
Drive by comment:<br>
While I do not know if this OK or not, you should explain why this change is required in your commit message.<br>
<br>
<a href="http://reviews.llvm.org/D7113" target="_blank">http://reviews.llvm.org/D7113</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/<u></u>settings/panel/<u></u>emailpreferences/</a><br>
<br>
<br>
<br>
______________________________<u></u>_________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/lldb-commits</a><br>
</blockquote></div>