[Lldb-commits] [PATCH] Fix darwin-debug build in cmake (OS X)

[Ilia K]

================
Comment at: scripts/Python/finishSwigPythonLLDB.py:342
@@ +341,3 @@
+#--
+def make_symlink_darwin_debug( vDictArgs, vstrFrameworkPythonDir, vstrDarwinDebugFileName ):
+	dbg = utilsDebug.CDebugFnVerbose( "Python script make_symlink_other_platforms()" );
----------------
zturner wrote:
> Thanks for adding this to the Python script.  Did you test the CMake build with both the shell script codepath and the python codepath?  (e.g. by trying both values for LLDB_DEFAULT_ENABLE_PYTHON_SCRIPTS_SWIG_API_GENERATION)?
No. Only python codepath. I can't test it with shell script codepath. "export LLDB_DEFAULT_ENABLE_PYTHON_SCRIPTS_SWIG_API_GENERATION=0" didn't help

================
Comment at: tools/darwin-debug/CMakeLists.txt:1
@@ +1,2 @@
+add_lldb_executable(lldb-launcher
+  darwin-debug.cpp
----------------
zturner wrote:
> Should the executable be called darwin-debug instead of lldb-launcher?
I don't mind. I took it from lldb.xcodeproj/project.pbxproj:
```
        26579F67126A25920007C5CB /* darwin-debug */ = {
            isa = PBXNativeTarget;
            buildConfigurationList = 26579F6D126A25BF0007C5CB /* Build configuration list for PBXNativeTarget "darwin-debug" */;
            buildPhases = (
                26579F65126A25920007C5CB /* Sources */,
                26579F66126A25920007C5CB /* Frameworks */,
            );
            buildRules = (
            );
            dependencies = (
            );
            name = "darwin-debug";
            productName = "lldb-launcher";
            productReference = 26579F68126A25920007C5CB /* darwin-debug */;
            productType = "com.apple.product-type.tool";
        };
```

http://reviews.llvm.org/D7102

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/