[Lldb-commits] [PATCH] Fix darwin-debug build in cmake (OS X)

Zachary Turner zturner at google.com
Wed Jan 21 11:08:13 PST 2015


================
Comment at: scripts/Python/finishSwigPythonLLDB.py:342
@@ +341,3 @@
+#--
+def make_symlink_darwin_debug( vDictArgs, vstrFrameworkPythonDir, vstrDarwinDebugFileName ):
+	dbg = utilsDebug.CDebugFnVerbose( "Python script make_symlink_other_platforms()" );
----------------
Thanks for adding this to the Python script.  Did you test the CMake build with both the shell script codepath and the python codepath?  (e.g. by trying both values for LLDB_DEFAULT_ENABLE_PYTHON_SCRIPTS_SWIG_API_GENERATION)?

================
Comment at: tools/darwin-debug/CMakeLists.txt:1
@@ +1,2 @@
+add_lldb_executable(lldb-launcher
+  darwin-debug.cpp
----------------
Should the executable be called darwin-debug instead of lldb-launcher?

http://reviews.llvm.org/D7102

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list