[Lldb-commits] [PATCH] lldb-mi: fix -stack-list-locals shows global variables

Ilia K ki.stfu at gmail.com
Mon Dec 8 09:50:06 PST 2014


Abid,

I don't have a commit access yet, but I would like to get it. Could you do
it by yourself?

Thanks,
Ilia

On Mon, Dec 8, 2014 at 8:32 PM, Abid, Hafiz <Hafiz_Abid at mentor.com> wrote:

>  Looks good to me. Please commit or let me know if you don’t have commit
> access. Thanks for fixing this.
>
>
>
> Regards,
>
> Abid
>
>
>
> *From:* Ilia K [mailto:ki.stfu at gmail.com]
> *Sent:* 05 December 2014 16:29
> *To:* lldb-commits at cs.uiuc.edu; Abid, Hafiz
> *Subject:* [Lldb-commits] [PATCH] lldb-mi: fix -stack-list-locals shows
> global variables
>
>
>
> Hello,
>
>
>
> This patch fixes the behaviour of -stack-list-locals command, which in
> additional lists global(static) variables. There was an error in ORing mask
> which is used for getting a list of variables. Previously, these constants
> were unnamed, and possible it become the reason of this bug.
>
>
>
> I had named these constants and done them as enumeration. Also, I added
> tests for -stack-list-locals and -stack-list-arguments commands.
>
>
>
> Thanks,
>
> Ilia
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141208/921d7dcf/attachment.html>


More information about the lldb-commits mailing list