[Lldb-commits] [PATCH] lldb-mi: fix -stack-list-locals shows global variables

Abid, Hafiz Hafiz_Abid at mentor.com
Mon Dec 8 09:32:03 PST 2014


Looks good to me. Please commit or let me know if you don’t have commit access. Thanks for fixing this.

Regards,
Abid

From: Ilia K [mailto:ki.stfu at gmail.com]
Sent: 05 December 2014 16:29
To: lldb-commits at cs.uiuc.edu; Abid, Hafiz
Subject: [Lldb-commits] [PATCH] lldb-mi: fix -stack-list-locals shows global variables

Hello,

This patch fixes the behaviour of -stack-list-locals command, which in additional lists global(static) variables. There was an error in ORing mask which is used for getting a list of variables. Previously, these constants were unnamed, and possible it become the reason of this bug.

I had named these constants and done them as enumeration. Also, I added tests for -stack-list-locals and -stack-list-arguments commands.

Thanks,
Ilia
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141208/e296da8b/attachment.html>


More information about the lldb-commits mailing list