[libcxx-commits] [PATCH] D90111: Partially implement C++20's P1020/P1973.

[Chris Kennelly via Phabricator via libcxx-commits]

ckennelly added a comment.

In D90111#2353912 <https://reviews.llvm.org/D90111#2353912>, @ldionne wrote:

> Thanks a lot for the patch! Do you think you could update the patch with the rest of the paper too? I'm fine reviewing it all in one patch (actually I find it easier to validate that the whole paper is implemented that way).

I looked at it, but I realized I needed to implement P0674R1 as a prereq for the `make_shared_for_overwrite` array bits, which looked more involved than trying to implement all 3 papers in one go

> Also, I don't see any feature test macro in the paper -- can you confirm that's the case, and that we're not forgetting to add one?

There is a feature test macro, but because I did not implement the `make_shared_for_overwrite` parts


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90111/new/

https://reviews.llvm.org/D90111