[libcxx-commits] [PATCH] D90111: Partially implement C++20's P1020/P1973.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Thanks a lot for the patch! Do you think you could update the patch with the rest of the paper too? I'm fine reviewing it all in one patch (actually I find it easier to validate that the whole paper is implemented that way).

Also, I don't see any feature test macro in the paper -- can you confirm that's the case, and that we're not forgetting to add one?



================
Comment at: libcxx/test/std/utilities/smartptr/unique.ptr/unique.ptr.create/make_unique_for_overwrite.array2.compile.fail.cpp:10-11
+#include <memory>
+#include <string>
+#include <cassert>
+
----------------
You don't need these includes (here and elsewhere).


================
Comment at: libcxx/test/std/utilities/smartptr/unique.ptr/unique.ptr.create/make_unique_for_overwrite.array3.compile.fail.cpp:14
+int main(int, char**) {
+  auto up3 = std::make_unique_for_overwrite<int[5]>(); // this is deleted
+
----------------
Can you make these tests be `.verify.cpp` instead, and check for the error message?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90111/new/

https://reviews.llvm.org/D90111