[libcxx-commits] [PATCH] D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY

[David Nicuesa via Phabricator via libcxx-commits]

Nicu added a comment.

In D86598#2242340 <https://reviews.llvm.org/D86598#2242340>, @ldionne wrote:

> In D86598#2242322 <https://reviews.llvm.org/D86598#2242322>, @miyuki wrote:
>
>> Sorry about that. I've reverted the change and will investigate.
>
> Thanks. I think the fix is just to remove the `inline` before `_LIBCPP_THREAD_ABI_VISIBILITY`, since `_LIBCPP_THREAD_ABI_VISIBILITY` already contains `inline` when not in the external threading library mode.

My bad, I did run tests but using the BUILD_EXTERNAL_THREAD_LIBRARY mode only, and forgot about the normal config.
As for the fix, if I remove that `inline` it breaks the external threading mode, but in order to fix that do you think is safe to change line 43 in `__threading_support` to `#define _LIBCPP_THREAD_ABI_VISIBILITY inline _LIBCPP_FUNC_VIS`. Adding the inline there?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86598/new/

https://reviews.llvm.org/D86598