[libcxx-commits] [PATCH] D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 27 08:51:25 PDT 2020


ldionne added a comment.

In D86598#2242322 <https://reviews.llvm.org/D86598#2242322>, @miyuki wrote:

> Sorry about that. I've reverted the change and will investigate.

Thanks. I think the fix is just to remove the `inline` before `_LIBCPP_THREAD_ABI_VISIBILITY`, since `_LIBCPP_THREAD_ABI_VISIBILITY` already contains `inline` when not in the external threading library mode.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86598/new/

https://reviews.llvm.org/D86598



More information about the libcxx-commits mailing list