[libcxx-commits] [PATCH] D68075: Do not #error if no OS is #defined
David Zarzycki via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Sep 26 07:38:28 PDT 2019
davezarzycki added a comment.
I think trying to work out of the box with zero tuning in common scenarios and minimal tuning with uncommon scenarios is the right approach. If it were up to me, I’d flip the test: If windows then set the Windows define, otherwise pthreads.h exists, assume pthreads. If somebody is compiling “freestanding” like myself, then a link error about missing pthreads is expected behavior.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits