[libcxx-commits] [PATCH] D68075: Do not #error if no OS is #defined

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Sep 26 07:20:37 PDT 2019

ldionne added a comment.

In D68075#1684174 <https://reviews.llvm.org/D68075#1684174>, @davezarzycki wrote:

> Hi @ldionne – That's a good question and I don't know the answer. If it's okay with you, I'd like to keep this change request narrowly focused on getting libcxx to work at all with freestanding environments.

My point is that it already does, when configured properly. If you specify `-DLIBCXX_ENABLE_THREADS=OFF`, you don't get the error you're seeing.

I think the larger point I'm trying to make is that we have a dual personality problem in libc++, where we try one the one hand to accommodate all systems from a single configuration of libc++, but we also have configuration options that would make libc++ work on that system without any code change. I'd like us (the libc++ maintainers) to figure this out.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list