[libcxx-commits] [PATCH] D66904: [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state
David Blaikie via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Sep 6 18:19:24 PDT 2019
dblaikie added a comment.
In D66904#1661872 <https://reviews.llvm.org/D66904#1661872>, @jgorbe wrote:
> It's just that it seemed weird/hacky to use asm just to stick assembler directives in the middle of the generated code instead of actual assembly, so I generated an assembly version and cleaned it up a bit. I'm happy to go back to the original shorter C++ version if that's not a concern.
Fair enough - I /think/ I'd lean towards source with inline assembly, but do feel free to wait for someone with more knowledge about this code/who can sign off in any case (with or without this change and others).
CHANGES SINCE LAST ACTION
More information about the libcxx-commits