[libcxx-commits] [PATCH] D66904: [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state

Jorge Gorbe Moya via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Sep 6 18:15:41 PDT 2019


jgorbe marked 2 inline comments as done.
jgorbe added inline comments.


================
Comment at: libunwind/test/remember_state_leak.pass.sh.s:5
+
+# The following main function is a translation of this code:
+#
----------------
dblaikie wrote:
> Other tests were written as .cpp file - is there a reason this one is all in assembly, compared to the .cpp with inline asm example you've given in the comment here?
See reply in commit-level comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66904/new/

https://reviews.llvm.org/D66904





More information about the libcxx-commits mailing list