[libcxx-commits] [PATCH] D68269: [libc++abi] Do not define new/delete by default

Dan Albert via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Oct 4 13:54:58 PDT 2019


danalbert added a comment.

> The alternative would be to only provide new/delete inside libc++abi, not in libc++ (by default). So, vendors (@phosek @srhines @danalbert @dim @emaste), are you OK with the default becoming that libc++abi provides new/delete, and libc++ DOES NOT (by default). If you want to keep shipping new/delete as part of libc++, you'll need to specify -DLIBCXX_ENABLE_NEW_DELETE_DEFINITIONS=ON at CMake configure time.

Also fine for Android. libc++abi and libc++ aren't separate (shared) libraries on Android, so it wouldn't make a difference for us.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68269/new/

https://reviews.llvm.org/D68269





More information about the libcxx-commits mailing list