[libcxx-commits] [PATCH] D68275: [libcxx] [test] Query the target platform, not the host one

Sergej Jaskiewicz via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 1 07:44:02 PDT 2019


broadwaylamb created this revision.
broadwaylamb added reviewers: jroelofs, danalbert, EricWF, thakis, mehdi_amini, arichardson, bcraig.
Herald added subscribers: libcxx-commits, ldionne, christof.
Herald added a project: libc++.

target_info is inferred to WindowsLocalTI on Windows hosts unless
specified otherwise. In the latter case, it doesn't make sense to use
Windows-specific settings if the target is not Windows.

This change should not break anything, because target_info is inferred
based on what platform.system() returns. self.is_windows was set based
on the same platform.system() call.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D68275

Files:
  libcxx/utils/libcxx/test/config.py
  libcxx/utils/libcxx/test/target_info.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68275.222614.patch
Type: text/x-patch
Size: 6795 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20191001/7c0955c1/attachment.bin>


More information about the libcxx-commits mailing list