[libcxx-commits] [PATCH] D69803: [libc++][P0784] Marked allocator_traits constexpr.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 4 08:17:08 PST 2019


ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/test/std/utilities/memory/allocator.traits/allocator.traits.members/deallocate.pass.cpp:54
+    Alloc a{called};
+    std::allocator_traits<Alloc >::deallocate(a, nullptr, 10);
     assert(called == 1);
----------------
This works, but I would be happier if we instead passed the address of an object, and checked that the right address had been passed in `A<T>::deallocate`. WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69803/new/

https://reviews.llvm.org/D69803





More information about the libcxx-commits mailing list