[libcxx-commits] [PATCH] D69803: [libc++][P0784] Marked allocator_traits constexpr.

[Michael Park via Phabricator via libcxx-commits]

mpark marked 2 inline comments as done.
mpark added inline comments.


================
Comment at: libcxx/test/std/utilities/memory/allocator.traits/allocator.traits.members/deallocate.pass.cpp:54
+    Alloc a{called};
+    std::allocator_traits<Alloc >::deallocate(a, nullptr, 10);
     assert(called == 1);
----------------
ldionne wrote:
> This works, but I would be happier if we instead passed the address of an object, and checked that the right address had been passed in `A<T>::deallocate`. WDYT?
Updated to pass an object in instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69803/new/

https://reviews.llvm.org/D69803