[libcxx-commits] [PATCH] D59344: Add contains method to map types

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked an inline comment as done.
zoecarver added inline comments.


================
Comment at: test/std/containers/contains.pass.cpp:1
+#include <cassert>
+#include <map>
----------------
ldionne wrote:
> EricWF wrote:
> > I really really REALLY like the way you wrote this test!
> > 
> > If a constraint is shared across all containers, or is specified in the container requirements table, then we should test it like this.
> Yes, I share that feeling.
Awesome! Happy you like it. 

@mclow.lists 
> We don't usually gang tests for multiple containers together - one/container is more common,
Do you want me to break this into multiple tests?


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59344/new/

https://reviews.llvm.org/D59344