[libcxx-commits] [PATCH] D59344: Add contains method to map types

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a reviewer: ldionne.
ldionne added inline comments.


================
Comment at: include/unordered_map:1268
         {return __table_.hash_function().hash_function();}
     _LIBCPP_INLINE_VISIBILITY
     key_equal key_eq() const
----------------
You forgot to add to the synopsis.


================
Comment at: test/std/containers/contains.pass.cpp:1
+#include <cassert>
+#include <map>
----------------
EricWF wrote:
> I really really REALLY like the way you wrote this test!
> 
> If a constraint is shared across all containers, or is specified in the container requirements table, then we should test it like this.
Yes, I share that feeling.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59344/new/

https://reviews.llvm.org/D59344