[PATCH] D56997: Fix implementation of P0966 - string::reserve Should Not Shrink

Wed Jan 23 10:19:28 PST 2019

andrewluo added a comment.

In D56997#1367748 <https://reviews.llvm.org/D56997#1367748>, @jwakely wrote:

> In D56997#1367316 <https://reviews.llvm.org/D56997#1367316>, @andrewluo wrote:
>
> > You are right, it is not guaranteed per the standard, although it has worked before (at least on MSVC).
>
>
> But not with libc++, where there were already two overloads. Changing that to support broken code which was already unsupported seems unnecessary.

Not in any released version of libc++, only after this change (which was made recently): https://reviews.llvm.org/D54992?id=175629

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56997/new/

https://reviews.llvm.org/D56997