[PATCH] D56997: Fix implementation of P0966 - string::reserve Should Not Shrink

Jonathan Wakely via Phabricator reviews at reviews.llvm.org
Wed Jan 23 07:04:36 PST 2019


jwakely added a comment.

In D56997#1367316 <https://reviews.llvm.org/D56997#1367316>, @andrewluo wrote:

> You are right, it is not guaranteed per the standard, although it has worked before (at least on MSVC).


But not with libc++, where there were already two overloads. Changing that to support broken code which was already unsupported seems unnecessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56997/new/

https://reviews.llvm.org/D56997





More information about the libcxx-commits mailing list