[libcxx-commits] [PATCH] D60535: [pstl] Remove the stdlib headers from the PSTL and move them to the tests

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Apr 11 15:15:21 PDT 2019


ldionne added a comment.

In D60535#1463401 <https://reviews.llvm.org/D60535#1463401>, @rodgert wrote:

> I'm not opposed to this change, but I wonder, should we then just remove the extra 'internal' directory, so that we get -
>
> pstl/numeric_impl.h
>
> ?
>
> Or should we move/rename the glue_Xxx files to pstl/ and keep everything else in pstl/internal ? Which is arguably now the library API after this change.


Yes, doing something like that was the next step I was planning. As a different patch, though. Everything that's not part of the API of the library would stay in `internal`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60535/new/

https://reviews.llvm.org/D60535





More information about the libcxx-commits mailing list