[libcxx-commits] [PATCH] D60535: [pstl] Remove the stdlib headers from the PSTL and move them to the tests

Thomas Rodgers via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Apr 11 14:14:43 PDT 2019


rodgert accepted this revision.
rodgert added a comment.
This revision is now accepted and ready to land.

I'm not opposed to this change, but I wonder, should we then just remove the extra 'internal' directory, so that we get -

pstl/numeric_impl.h

?

Or should we move/rename the glue_Xxx files to pstl/ and keep everything else in pstl/internal ? Which is arguably now the library API after this change.

for libstdc++ I currently move 'internal' into 'pstl' so if do move/rename the glue files, I'd need to update my script (not an argument against doing this).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60535/new/

https://reviews.llvm.org/D60535





More information about the libcxx-commits mailing list