[libcxx-commits] [PATCH] D60422: Remove default parameters (P0935R0)

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked 2 inline comments as done.
zoecarver added a comment.

Sounds good. I will work on tests for these on a plane ride I have Sunday.



================
Comment at: include/queue:454
+        _NOEXCEPT_(is_nothrow_default_constructible<container_type>::value &&
+                   is_nothrow_default_constructible<value_compare>::value)
+        : priority_queue(__x, _Container()) {}
----------------
EricWF wrote:
> copy paste error? we are copy constructing the comparator
Yes, my bad. I should get rid of this and keep line 470-472.


================
Comment at: lib/CMakeLists.txt:202
+      "-compatibility_version 1"
+      "-install_name /usr/lib/libc++.1.dylib"
       "-Wl,-unexported_symbols_list,${CMAKE_CURRENT_SOURCE_DIR}/libc++unexp.exp"
----------------
EricWF wrote:
> bad diff?
Yep, forgot to pull from master first. Sorry.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60422/new/

https://reviews.llvm.org/D60422