[libcxx-commits] [PATCH] D60422: Remove default parameters (P0935R0)
Eric Fiselier via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Apr 9 19:08:13 PDT 2019
EricWF added a comment.
Every line of this change should be covered by a test
================
Comment at: include/queue:454
+ _NOEXCEPT_(is_nothrow_default_constructible<container_type>::value &&
+ is_nothrow_default_constructible<value_compare>::value)
+ : priority_queue(__x, _Container()) {}
----------------
copy paste error? we are copy constructing the comparator
================
Comment at: lib/CMakeLists.txt:202
+ "-compatibility_version 1"
+ "-install_name /usr/lib/libc++.1.dylib"
"-Wl,-unexported_symbols_list,${CMAKE_CURRENT_SOURCE_DIR}/libc++unexp.exp"
----------------
bad diff?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60422/new/
https://reviews.llvm.org/D60422
More information about the libcxx-commits
mailing list