[libcxx-commits] [PATCH] D60422: Remove default parameters (P0935R0)

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 9 06:50:21 PDT 2019


zoecarver marked an inline comment as done.
zoecarver added inline comments.


================
Comment at: include/queue:42
 
+    queue() : queue(container_type()) {}
     explicit queue(const container_type& c);
----------------
ldionne wrote:
> We normally don't show the definition of functions in the synopsis. Also notice that this default constructor already appears above.
Your right, guess I didn't see that. I will get rid of the added constructor. For the below constructors, would it be helpful to keep them in the synopsis because they show what the default value is? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60422/new/

https://reviews.llvm.org/D60422





More information about the libcxx-commits mailing list