[libcxx-commits] [PATCH] D60422: Remove default parameters (P0935R0)

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

> Also, I used `_LIBCPP_INLINE_VISIBILITY` where it looked like other's were using it. What is the rule of thumb for `_LIBCPP_INLINE_VISIBILITY`?

Use it for functions that you don't want to be part of the ABI. In this case, every default constructor that simply forwards to another constructor should be marked with `_LIBCPP_INLINE_VISIBILITY`.



================
Comment at: include/queue:42
 
+    queue() : queue(container_type()) {}
     explicit queue(const container_type& c);
----------------
We normally don't show the definition of functions in the synopsis. Also notice that this default constructor already appears above.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60422/new/

https://reviews.llvm.org/D60422