[libcxx-commits] [PATCH] D60372: [gn] Support for building libcxxabi

[Nico Weber via Phabricator via libcxx-commits]

thakis added a comment.

Basically lgtm, some questions about the declare_args (mirroring https://reviews.llvm.org/D60253#1456632 a bit)



================
Comment at: llvm/utils/gn/secondary/libcxxabi/src/BUILD.gn:5
+  # Use exceptions.
+  libcxxabi_enable_exceptions = true
+
----------------
Does this one have to be settable? That seems like an implementation detail from a distance.


================
Comment at: llvm/utils/gn/secondary/libcxxabi/src/BUILD.gn:17
+  # Do not export any symbols from the static library.
+  libcxxabi_hermetic_static_library = false
+}
----------------
Wouldn't you always want this? What's an example where one would want to statically link c++abi but export its symbols? They only thing I can think of is when linking it into libc++.dylib, which which case we probably want a toggle for that instead?

Why is the default false? Why is this settable?


================
Comment at: llvm/utils/gn/secondary/libcxxabi/src/BUILD.gn:38
+
+  # C++ STL files"
+  "stdlib_exception.cpp",
----------------
no trailing "


Repository:
  rCXXA libc++abi

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60372/new/

https://reviews.llvm.org/D60372