[libcxx-commits] [PATCH] D60372: [gn] Support for building libcxxabi

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.
Herald added a subscriber: dexonsmith.

LLVM uses CMake as a build system, and we should not start checking-in support for other build systems. This sort of thing is what's fine to keep downstream only, otherwise there's an implication that upstream should somehow support that build system, which isn't the case. For example, when we make a change to CMake, we don't want to have to update the gn-based build system.

Similarly, we use a Xcode project to build libc++/libc++abi/libunwind, but we don't check those in upstream (and I've been working hard to switch us over to the CMake build, actually).


Repository:
  rCXXA libc++abi

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60372/new/

https://reviews.llvm.org/D60372