[libcxx-commits] [PATCH] D60145: libcxx: Add _LIBCPP_NODISCARD_EXT to 37 more functions

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 3 10:45:27 PDT 2019


EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

When LIT says "N warnings in tests" It's not talking about warnings compiling code; it's refering to warnings while configuring the test suite.

Our tests all run with -Werror enabled and system header pragmas within libc++ disabled.

This LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60145/new/

https://reviews.llvm.org/D60145





More information about the libcxx-commits mailing list