[libcxx-commits] [PATCH] D60145: libcxx: Add _LIBCPP_NODISCARD_EXT to 37 more functions

Wed Apr 3 09:39:48 PDT 2019

mclow.lists added a comment.

In D60145#1453278 <https://reviews.llvm.org/D60145#1453278>, @thakis wrote:

> In D60145#1453181 <https://reviews.llvm.org/D60145#1453181>, @mclow.lists wrote:
>
> > I'm a bit worried about nodiscard_extensions.pass.cpp, because `lit` by default does not show warnings; just "N warnings in tests" in the summary.
>
>
> (That would apply to the previous version of the test too, right?)
>
> lit prints this for me (note -Werror):

[snip]

> Does that address your concern?

Not really, because of the "for me" bit. [ I believe that it's something that people can configure. ]
What I want to ensure is that this test doesn't start giving warnings, and I'm not sure how to do that.

I will do some looking into this and get back to you. Don't make any changes for the moment.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60145/new/

https://reviews.llvm.org/D60145