[libcxx-commits] [libcxx] r347046 - Remove BUILD file from google-benchmark

[Eric Fiselier]

We should probably document that we need to remove the `BUILD` files when
upgrading the library.

On Fri, Nov 16, 2018 at 8:51 AM Benjamin Kramer via libcxx-commits <
libcxx-commits at lists.llvm.org> wrote:

>
>
>
> ---------- Forwarded message ----------
> From: Benjamin Kramer <benny.kra at googlemail.com>
> To: libcxx-commits at lists.llvm.org
> Cc:
> Bcc:
> Date: Fri, 16 Nov 2018 12:53:17 -0000
> Subject: [libcxx] r347046 - Remove BUILD file from google-benchmark
> Author: d0k
> Date: Fri Nov 16 04:53:17 2018
> New Revision: 347046
>
> URL: http://llvm.org/viewvc/llvm-project?rev=347046&view=rev
> Log:
> Remove BUILD file from google-benchmark
>
> This was removed in r336666, but accidentally re-added in r346984.
>
> Removed:
>     libcxx/trunk/utils/google-benchmark/test/BUILD
>
> Removed: libcxx/trunk/utils/google-benchmark/test/BUILD
> URL:
> http://llvm.org/viewvc/llvm-project/libcxx/trunk/utils/google-benchmark/test/BUILD?rev=347045&view=auto
>
> ==============================================================================
> --- libcxx/trunk/utils/google-benchmark/test/BUILD (original)
> +++ libcxx/trunk/utils/google-benchmark/test/BUILD (removed)
> @@ -1,65 +0,0 @@
> -TEST_COPTS = [
> -    "-pedantic",
> -    "-pedantic-errors",
> -    "-std=c++11",
> -    "-Wall",
> -    "-Wextra",
> -    "-Wshadow",
> -#    "-Wshorten-64-to-32",
> -    "-Wfloat-equal",
> -    "-fstrict-aliasing",
> -]
> -
> -PER_SRC_COPTS = ({
> -    "cxx03_test.cc": ["-std=c++03"],
> -    # Some of the issues with DoNotOptimize only occur when optimization
> is enabled
> -    "donotoptimize_test.cc": ["-O3"],
> -})
> -
> -
> -TEST_ARGS = ["--benchmark_min_time=0.01"]
> -
> -PER_SRC_TEST_ARGS = ({
> -    "user_counters_tabular_test.cc":
> ["--benchmark_counters_tabular=true"],
> -})
> -
> -cc_library(
> -    name = "output_test_helper",
> -    testonly = 1,
> -    srcs = ["output_test_helper.cc"],
> -    hdrs = ["output_test.h"],
> -    copts = TEST_COPTS,
> -    deps = [
> -        "//:benchmark",
> -        "//:benchmark_internal_headers",
> -    ],
> -)
> -
> -[
> -  cc_test(
> -    name = test_src[:-len(".cc")],
> -    size = "small",
> -    srcs = [test_src],
> -    args = TEST_ARGS + PER_SRC_TEST_ARGS.get(test_src, []),
> -    copts = TEST_COPTS + PER_SRC_COPTS.get(test_src, []),
> -    deps = [
> -        ":output_test_helper",
> -        "//:benchmark",
> -        "//:benchmark_internal_headers",
> -        "@com_google_googletest//:gtest",
> -    ] + (
> -        ["@com_google_googletest//:gtest_main"] if
> (test_src[-len("gtest.cc"):] == "gtest.cc") else []
> -    ),
> -  # FIXME: Add support for assembly tests to bazel.
> -  # See Issue #556
> -  # https://github.com/google/benchmark/issues/556
> -  ) for test_src in glob(["*test.cc"], exclude = ["*_assembly_test.cc",
> "link_main_test.cc"])
> -]
> -
> -cc_test(
> -    name = "link_main_test",
> -    size = "small",
> -    srcs = ["link_main_test.cc"],
> -    copts = TEST_COPTS,
> -    deps = ["//:benchmark_main"],
> -)
>
>
>
>
>
> ---------- Forwarded message ----------
> From: Benjamin Kramer via libcxx-commits <libcxx-commits at lists.llvm.org>
> To: libcxx-commits at lists.llvm.org
> Cc:
> Bcc:
> Date: Fri, 16 Nov 2018 05:48:39 -0800 (PST)
> Subject: [libcxx-commits] [libcxx] r347046 - Remove BUILD file from
> google-benchmark
> _______________________________________________
> libcxx-commits mailing list
> libcxx-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20181116/fc5ba410/attachment-0001.html>