<div dir="ltr">We should probably document that we need to remove the `BUILD` files when upgrading the library.</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Nov 16, 2018 at 8:51 AM Benjamin Kramer via libcxx-commits <<a href="mailto:libcxx-commits@lists.llvm.org">libcxx-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br><br><br>---------- Forwarded message ----------<br>From: Benjamin Kramer <<a href="mailto:benny.kra@googlemail.com" target="_blank">benny.kra@googlemail.com</a>><br>To: <a href="mailto:libcxx-commits@lists.llvm.org" target="_blank">libcxx-commits@lists.llvm.org</a><br>Cc: <br>Bcc: <br>Date: Fri, 16 Nov 2018 12:53:17 -0000<br>Subject: [libcxx] r347046 - Remove BUILD file from google-benchmark<br>Author: d0k<br>
Date: Fri Nov 16 04:53:17 2018<br>
New Revision: 347046<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=347046&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=347046&view=rev</a><br>
Log:<br>
Remove BUILD file from google-benchmark<br>
<br>
This was removed in r336666, but accidentally re-added in r346984.<br>
<br>
Removed:<br>
    libcxx/trunk/utils/google-benchmark/test/BUILD<br>
<br>
Removed: libcxx/trunk/utils/google-benchmark/test/BUILD<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/utils/google-benchmark/test/BUILD?rev=347045&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/libcxx/trunk/utils/google-benchmark/test/BUILD?rev=347045&view=auto</a><br>
==============================================================================<br>
--- libcxx/trunk/utils/google-benchmark/test/BUILD (original)<br>
+++ libcxx/trunk/utils/google-benchmark/test/BUILD (removed)<br>
@@ -1,65 +0,0 @@<br>
-TEST_COPTS = [<br>
-    "-pedantic",<br>
-    "-pedantic-errors",<br>
-    "-std=c++11",<br>
-    "-Wall",<br>
-    "-Wextra",<br>
-    "-Wshadow",<br>
-#    "-Wshorten-64-to-32",<br>
-    "-Wfloat-equal",<br>
-    "-fstrict-aliasing",<br>
-]<br>
-<br>
-PER_SRC_COPTS = ({<br>
-    "cxx03_test.cc": ["-std=c++03"],<br>
-    # Some of the issues with DoNotOptimize only occur when optimization is enabled<br>
-    "donotoptimize_test.cc": ["-O3"],<br>
-})<br>
-<br>
-<br>
-TEST_ARGS = ["--benchmark_min_time=0.01"]<br>
-<br>
-PER_SRC_TEST_ARGS = ({<br>
-    "user_counters_tabular_test.cc": ["--benchmark_counters_tabular=true"],<br>
-})<br>
-<br>
-cc_library(<br>
-    name = "output_test_helper",<br>
-    testonly = 1,<br>
-    srcs = ["output_test_helper.cc"],<br>
-    hdrs = ["output_test.h"],<br>
-    copts = TEST_COPTS,<br>
-    deps = [<br>
-        "//:benchmark",<br>
-        "//:benchmark_internal_headers",<br>
-    ],<br>
-)<br>
-<br>
-[<br>
-  cc_test(<br>
-    name = test_src[:-len(".cc")],<br>
-    size = "small",<br>
-    srcs = [test_src],<br>
-    args = TEST_ARGS + PER_SRC_TEST_ARGS.get(test_src, []),<br>
-    copts = TEST_COPTS + PER_SRC_COPTS.get(test_src, []),<br>
-    deps = [<br>
-        ":output_test_helper",<br>
-        "//:benchmark",<br>
-        "//:benchmark_internal_headers",<br>
-        "@com_google_googletest//:gtest",<br>
-    ] + (<br>
-        ["@com_google_googletest//:gtest_main"] if (test_src[-len("gtest.cc"):] == "gtest.cc") else []<br>
-    ),<br>
-  # FIXME: Add support for assembly tests to bazel.<br>
-  # See Issue #556<br>
-  # <a href="https://github.com/google/benchmark/issues/556" rel="noreferrer" target="_blank">https://github.com/google/benchmark/issues/556</a><br>
-  ) for test_src in glob(["*test.cc"], exclude = ["*_assembly_test.cc", "link_main_test.cc"])<br>
-]<br>
-<br>
-cc_test(<br>
-    name = "link_main_test",<br>
-    size = "small",<br>
-    srcs = ["link_main_test.cc"],<br>
-    copts = TEST_COPTS,<br>
-    deps = ["//:benchmark_main"],<br>
-)<br>
<br>
<br>
<br><br><br>---------- Forwarded message ----------<br>From: Benjamin Kramer via libcxx-commits <<a href="mailto:libcxx-commits@lists.llvm.org" target="_blank">libcxx-commits@lists.llvm.org</a>><br>To: <a href="mailto:libcxx-commits@lists.llvm.org" target="_blank">libcxx-commits@lists.llvm.org</a><br>Cc: <br>Bcc: <br>Date: Fri, 16 Nov 2018 05:48:39 -0800 (PST)<br>Subject: [libcxx-commits] [libcxx] r347046 - Remove BUILD file from google-benchmark<br>_______________________________________________<br>
libcxx-commits mailing list<br>
<a href="mailto:libcxx-commits@lists.llvm.org" target="_blank">libcxx-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits</a><br>
</blockquote></div>